https://bugzilla.redhat.com/show_bug.cgi?id=1051771 --- Comment #8 from Mohamed El Morabity <pikachu.2014@xxxxxxxxx> --- Hello, some comments: - it looks like the package doesn't build on F20 and Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=6457561 (rawhide) http://koji.fedoraproject.org/koji/taskinfo?taskID=6457430 (F20) You try to build vdr-tvguide against graphicsmagick: make CFLAGS="%{optflags}" IMAGELIB=graphicsmagick %{?_smp_mflags} all whereas your package depends on ImageMagick-c++-devel. As a result, drop "IMAGELIB=..." to link against ImageMagick (this seems to be the default), or replace your BR on ImageMagick-c++-devel by GraphicsMagick-c++-devel if you have a reason to use GraphicsMagick instead. - since the package is written in C++, and since the CXXFLAGS variable is handled by the plugin Makefile, you must also set CXXFLAGS when calling make, to keep consistency on build flags: make CFLAGS="%{optflags}" CXXFLAGS="%{optflags}" ... You should even add -fPIC to both CFLAGS and CXXFLAGS to handle build issues on x86_64 platforms. - a stable release 1.0.0 is available. Why do you need to use a development snapshot? - I wonder if a subpackage for themes is really necessary: * the data subpackage is not very heavy * the subpackage is useless "standalone" * I don't think the data subpackage would be required by any other package than vdr-tvguide. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review