[Bug 1049546] Review Request: mingw-freeimage - MinGW Windows freeimage library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1049546

František Dvořák <valtri@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |valtri@xxxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #9 from František Dvořák <valtri@xxxxxxxxxx> ---
I helped with a patch, but let's say I'm not disqualified from doing a review.
:-)

Found issues:

- Source/ZLib needs to be also deleted.

  Generator scripts add all directories with header files to includes paths, so
there would be accidentaly used local bundled headers, which could be
incompatible with zlib library binary.

- rpmlint (mingw-freeimage.src): strange-permission FreeImage3154.zip 0600L

  Usually, a file should have 0644 permissions.

- rpmlint: file-not-utf8 /usr/share/doc/mingw32-freeimage/license-gplv3.txt,
/usr/share/doc/mingw32-freeimage/Whatsnew.txt

  It is only about quotation marks there. I think the files are in cp1252
encoding (Western European for Windows), but cp1250 would work too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]