https://bugzilla.redhat.com/show_bug.cgi?id=1045556 Ralf Corsepius <rc040203@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rc040203@xxxxxxxxxx --- Comment #14 from Ralf Corsepius <rc040203@xxxxxxxxxx> --- (In reply to Haïkel Guémar from comment #12) > According guidelines: > "If the source code of the package provides a test suite, it *should* be > executed in the %check section, whenever it is *practical* to do so." > > First, enabling tests is not mandatory, it's strongly advised to execute > them. > Then, the guideline insists on the fact it is practical to do so, so it's up > to the packager or the reviewer judgement. Well, the FPG's formulation isn't aiming at "testsuite execution speed", it is aiming at packages whose testsuite's complexity would overly complicate packaging a package. In other words it's meant to prevent case where sloppily written crap-ware would not pass reviews, while packages with very evolved and complex testsuites would not pass reviews. That said, * 20 mins of testsuite execution time is not extraordinary. * Nothing prevents a packager to add --with/--without conditionals (with a default to execise the testsuite) to an rpm-spec to speed up local testbuilding. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review