https://bugzilla.redhat.com/show_bug.cgi?id=1045556 --- Comment #12 from Haïkel Guémar <karlthered@xxxxxxxxx> --- According guidelines: "If the source code of the package provides a test suite, it *should* be executed in the %check section, whenever it is *practical* to do so." First, enabling tests is not mandatory, it's strongly advised to execute them. Then, the guideline insists on the fact it is practical to do so, so it's up to the packager or the reviewer judgement. Since, the execution of the tests suite takes up to 20 minutes, i personnally consider this to be a legit argument no to enable them. My personal choice would have been to enable them by default, and allowing people to quickly rebuild it if requires. As a reviewer, i can only make suggestions to the packager on that point: "consider using a build conditional so one could easily enable or better disable test suite execution". My duty as a reviewer is not to enforce my POV, just the guidelines and ensure high quality packaging and that's the case here. That's why i approved this package, and i trust my fellow packager to do the right choice on that matter. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review