[Bug 1048493] Review Request: icecat - GNU version of Firefox browser

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1048493

Denis Fateyev <denis@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(denis@xxxxxxxxxxx |
                   |)                           |



--- Comment #9 from Denis Fateyev <denis@xxxxxxxxxxx> ---
(In reply to Antonio Trande from comment #8)
>  
> > 2) "Package contains no bundled libraries without FPC exception" - have no
> > idea whether it's actual here, could you check them, or clear the issue
> > providing more details?
> 
> I've tried to remove some of them. However it seems to me that some sources
> from third cannot be cancelled without break the compilation (for example,
> there is not any build config option to use libvorbis system libraries; this
> happens for xulrunner currently built in Fedora as well). 

I've just looked through the spec and recent changes. Anyway, I think you
should try something with CFLAGS/LDFLAGS to minimize bundled libs as much as
possible. These libraries mentioned in spec..

> ## --with-system-png won't work because the system's libpng doesn't have APNG support
> ## libpng in source tree are necessary
> #rm -f media/libpng/png.h
> #rm -f media/libpng/pngconf.h

> ##It doesn't seems possible to remove these library sources
> ##without break the compilation
> #rm -rf media/libtheora
> #rm -rf media/libvorbis
> #rm -f media/libogg/include/ogg/*.h
> #rm -f media/libopus/include/*.h

.. are not explicitly allowed to be bundled in packages. I've also noticed
"libffi" references which is already packaged in Fedora. For bundled libraries
policy, you may refer this document for details:
https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries
This is a stopper here. I doubt we can omit this requirement.

> > 3) Multiple issues with "%{mozappdir}" should be sorted;

Can you reduce the amount of warnings related to that? Seems there was also a
'rpmlint' complain.

> > 4) Why not to use "xulrunner" already packaged in Fedora?

> To avoid possible incompatibilities between xulrunner in Fedora and Icecat in future.

Same applied here, could you test with the system xulrunner anyway?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]