Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: concurrent https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225653 ------- Additional Comments From pcheung@xxxxxxxxxx 2007-03-30 12:04 EST ------- (In reply to comment #2) > * is it legal for Fedora to distribute this? > - OSI-approved > - not a kernel module > - not shareware > - is it covered by patents? > - it *probably* shouldn't be an emulator > - no binary firmware > X I don't know if we can just distribute this. The project claims to be in the > public domain but sections of it are covered by a Technology License from Sun > Microsystems Inc. > (http://gee.cs.oswego.edu/dl/classes/EDU/oswego/cs/dl/util/sun-u.c.license.pdf) > This is OK as Public Domain, please see https://www.redhat.com/archives/fedora-packaging/2007-March/msg00142.html > * license field matches the actual license. > X the license field does not mention the Technology License As noted in the message on the mailing list > > * license is open source-compatible. > - use acronyms for licences where common > X I don't know if the Technology License is open source-compatible > Same as above. > * license text included in package and marked with %doc > X The source does not include a specific license file, but it does mention the > terms of the license in the intro.html file included. This file has a broken > link to the Sun Technology license which should be patched. > No license file as it is Public Domain, and I fixed the link in intro.html > * rpmlint on <this package>.srpm gives no output > rpmlint concurrent-1.3.4-5jpp.1.fc7.src.rpm > W: concurrent non-standard-group Development/Libraries/Java > W: concurrent strange-permission concurrent.tar.gz 0660 > W: concurrent strange-permission concurrent-1.3.4.build.xml 0660 > W: concurrent strange-permission concurrent.spec 0640 > > X please fix these permission issues Fixed. > X package fails in mock. > I will continue the review once the package can be built properly and the > licensing issues are resolved. > > Error in mock build: > cp: cannot stat `intro.html': No such file or directory Fixed. Updated spec and srpm at the same location. Thanks -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review