https://bugzilla.redhat.com/show_bug.cgi?id=1051915 Paul Wouters <pwouters@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Paul Wouters <pwouters@xxxxxxxxxx> --- APPROVED, but please look at fixing the minor items found Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed minor issues: License should be changed from "BSD" to "BSD with advertising" silvia.src: E: description-line-too-long C SImple Library for the Verification and Issuance of Attributes of IRMA cards (irmacard.org). I know its their name, perhaps not explain the acronym in the summary? "Attribute library for IRMA cards" perhaps? Can you report to upstream regarding obsoleted AC_PROG_LIBTOOL? ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (2 clause)", "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/paul/silvia/licensecheck.txt [-]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [ ]: Scriptlets must be sane, if used. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: silvia-0.2.2-0.1.01425e8git.fc20.x86_64.rpm silvia-devel-0.2.2-0.1.01425e8git.fc20.x86_64.rpm silvia-0.2.2-0.1.01425e8git.fc20.src.rpm silvia.x86_64: W: spelling-error Summary(en_US) SImple -> Simple, Sample, Dimple silvia.x86_64: W: spelling-error %description -l en_US SImple -> Simple, Sample, Dimple silvia.x86_64: W: spelling-error %description -l en_US irmacard -> cardiac silvia.x86_64: E: description-line-too-long C SImple Library for the Verification and Issuance of Attributes of IRMA cards (irmacard.org). silvia.x86_64: W: no-manual-page-for-binary silvia_issuer silvia.x86_64: W: no-manual-page-for-binary silvia_verifier silvia.x86_64: W: no-manual-page-for-binary silvia_keygen silvia.x86_64: W: no-manual-page-for-binary silvia_loader silvia-devel.x86_64: W: no-documentation silvia.src: W: spelling-error Summary(en_US) SImple -> Simple, Sample, Dimple silvia.src: W: spelling-error %description -l en_US SImple -> Simple, Sample, Dimple silvia.src: W: spelling-error %description -l en_US irmacard -> cardiac silvia.src: E: description-line-too-long C SImple Library for the Verification and Issuance of Attributes of IRMA cards (irmacard.org). silvia.src: W: invalid-url Source0: silvia-01425e8.tar.gz 3 packages and 0 specfiles checked; 2 errors, 12 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint silvia silvia-devel silvia.x86_64: W: spelling-error Summary(en_US) SImple -> Simple, Sample, Dimple silvia.x86_64: W: spelling-error %description -l en_US SImple -> Simple, Sample, Dimple silvia.x86_64: W: spelling-error %description -l en_US irmacard -> cardiac silvia.x86_64: E: description-line-too-long C SImple Library for the Verification and Issuance of Attributes of IRMA cards (irmacard.org). silvia.x86_64: W: undefined-non-weak-symbol /usr/lib64/libsilvia.so.0.0.1 vtable for __cxxabiv1::__class_type_info silvia.x86_64: W: undefined-non-weak-symbol /usr/lib64/libsilvia.so.0.0.1 __cxa_pure_virtual silvia.x86_64: W: undefined-non-weak-symbol /usr/lib64/libsilvia.so.0.0.1 vtable for __cxxabiv1::__si_class_type_info silvia.x86_64: W: undefined-non-weak-symbol /usr/lib64/libsilvia.so.0.0.1 std::invalid_argument::~invalid_argument() silvia.x86_64: W: undefined-non-weak-symbol /usr/lib64/libsilvia.so.0.0.1 typeinfo for std::invalid_argument silvia.x86_64: W: undefined-non-weak-symbol /usr/lib64/libsilvia.so.0.0.1 std::basic_string<char, std::char_traits<char>, std::allocator<char> >::_Rep::_S_empty_rep_storage silvia.x86_64: W: undefined-non-weak-symbol /usr/lib64/libsilvia.so.0.0.1 __gxx_personality_v0 silvia.x86_64: W: undefined-non-weak-symbol /usr/lib64/libsilvia.so.0.0.1 std::basic_string<char, std::char_traits<char>, std::allocator<char> >::assign(std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) silvia.x86_64: W: undefined-non-weak-symbol /usr/lib64/libsilvia.so.0.0.1 __cxa_rethrow silvia.x86_64: W: undefined-non-weak-symbol /usr/lib64/libsilvia.so.0.0.1 std::basic_string<char, std::char_traits<char>, std::allocator<char> >::compare(char const*) const silvia.x86_64: W: undefined-non-weak-symbol /usr/lib64/libsilvia.so.0.0.1 std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(char const*, unsigned long, std::allocator<char> const&) silvia.x86_64: W: undefined-non-weak-symbol /usr/lib64/libsilvia.so.0.0.1 std::basic_string<char, std::char_traits<char>, std::allocator<char> >::assign(char const*, unsigned long) silvia.x86_64: W: undefined-non-weak-symbol /usr/lib64/libsilvia.so.0.0.1 operator new(unsigned long) silvia.x86_64: W: undefined-non-weak-symbol /usr/lib64/libsilvia.so.0.0.1 std::__throw_bad_alloc() silvia.x86_64: W: undefined-non-weak-symbol /usr/lib64/libsilvia.so.0.0.1 __cxa_throw silvia.x86_64: W: undefined-non-weak-symbol /usr/lib64/libsilvia.so.0.0.1 operator delete(void*) silvia.x86_64: W: undefined-non-weak-symbol /usr/lib64/libsilvia.so.0.0.1 std::invalid_argument::invalid_argument(std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) silvia.x86_64: W: undefined-non-weak-symbol /usr/lib64/libsilvia.so.0.0.1 std::basic_string<char, std::char_traits<char>, std::allocator<char> >::_Rep::_M_destroy(std::allocator<char> const&) silvia.x86_64: W: undefined-non-weak-symbol /usr/lib64/libsilvia.so.0.0.1 std::terminate() silvia.x86_64: W: undefined-non-weak-symbol /usr/lib64/libsilvia.so.0.0.1 std::basic_string<char, std::char_traits<char>, std::allocator<char> >::_Rep::_M_dispose(std::allocator<char> const&) silvia.x86_64: W: undefined-non-weak-symbol /usr/lib64/libsilvia.so.0.0.1 __cxa_free_exception silvia.x86_64: W: undefined-non-weak-symbol /usr/lib64/libsilvia.so.0.0.1 std::basic_string<char, std::char_traits<char>, std::allocator<char> >::append(std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) silvia.x86_64: W: undefined-non-weak-symbol /usr/lib64/libsilvia.so.0.0.1 std::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_leak_hard() silvia.x86_64: W: undefined-non-weak-symbol /usr/lib64/libsilvia.so.0.0.1 __cxa_begin_catch silvia.x86_64: W: undefined-non-weak-symbol /usr/lib64/libsilvia.so.0.0.1 std::basic_string<char, std::char_traits<char>, std::allocator<char> >::append(char const*, unsigned long) silvia.x86_64: W: undefined-non-weak-symbol /usr/lib64/libsilvia.so.0.0.1 __cxa_end_catch silvia.x86_64: W: undefined-non-weak-symbol /usr/lib64/libsilvia.so.0.0.1 __cxa_call_unexpected silvia.x86_64: W: undefined-non-weak-symbol /usr/lib64/libsilvia.so.0.0.1 std::basic_string<char, std::char_traits<char>, std::allocator<char> >::reserve(unsigned long) silvia.x86_64: W: undefined-non-weak-symbol /usr/lib64/libsilvia.so.0.0.1 __cxa_allocate_exception silvia.x86_64: W: undefined-non-weak-symbol /usr/lib64/libsilvia.so.0.0.1 std::__throw_length_error(char const*) silvia.x86_64: W: undefined-non-weak-symbol /usr/lib64/libsilvia.so.0.0.1 std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(char const*, std::allocator<char> const&) silvia.x86_64: W: undefined-non-weak-symbol /usr/lib64/libsilvia.so.0.0.1 std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) silvia.x86_64: W: undefined-non-weak-symbol /usr/lib64/libsilvia.so.0.0.1 std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned long, unsigned long) silvia.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsilvia.so.0.0.1 /lib64/libusb-0.1.so.4 silvia.x86_64: W: no-manual-page-for-binary silvia_issuer silvia.x86_64: W: no-manual-page-for-binary silvia_verifier silvia.x86_64: W: no-manual-page-for-binary silvia_keygen silvia.x86_64: W: no-manual-page-for-binary silvia_loader silvia-devel.x86_64: W: no-documentation 2 packages and 0 specfiles checked; 1 errors, 42 warnings. # echo 'rpmlint-done:' Requires -------- silvia (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libcrypto.so.10()(64bit) libcrypto.so.10(libcrypto.so.10)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgmp.so.10()(64bit) libm.so.6()(64bit) libnfc.so.5()(64bit) libpcsclite.so.1()(64bit) libpthread.so.0()(64bit) libsilvia.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libusb-0.1.so.4()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) rtld(GNU_HASH) silvia-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libsilvia.so.0()(64bit) silvia(x86-64) Provides -------- silvia: libsilvia.so.0()(64bit) silvia silvia(x86-64) silvia-devel: pkgconfig(silvia) silvia-devel silvia-devel(x86-64) AutoTools: Obsoleted m4s found ------------------------------ AC_PROG_LIBTOOL found in: silvia-0.2.2/configure.ac:56 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review