https://bugzilla.redhat.com/show_bug.cgi?id=1051901 --- Comment #8 from Sam Kottler <skottler@xxxxxxxxxx> --- (In reply to Vít Ondruch from comment #7) > * Don't introduce additional requires > - Upstream does not like them > - They are useless, probably except tests with Ruby 1.8.7 I just changed it to use RUBYOPTS to load rubygems before running the test suite. > > * Mark the license by %doc macro > - Please mark the %{gem_instdir}/MIT-LICENSE as a documentation. > > > > * rpmlint > > > - rpmlint complains about wrong-file-end-of-line-encoding a lot. This > > > might be > > > better to check with upstream. > > > - rubygem-rgen-doc.noarch: W: file-not-utf8 /usr/share/gems/gems/rgen- > > > 0.6.6/test/testmodel/ea_testmodel.xml error seems to be false positive, > > > since the XML explicitly says it is windows-1252 encoded. Probably > > > nothing > > > we can do about it. > > > > I'll start working with the upstream to fix this. > > Interesting, now I cannot reproduce these issues. Rpmlint now complains just > about CHANGELOG. This is probably updated file utility. > > Nevertheless, is there any upstream ticket for this? Not yet, I'll create one today. I haven't actually tried to reproduce it, but will do that again to see if I can recreate what you've seen before filing the ticket. > > Otherwise, the package looks ok => APPROVED. Please fix the minor nits I > have mentioned above prior importing. Thanks, Vit! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review