Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: SimGear - Simulation library components https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208678 ------- Additional Comments From j.w.r.degoede@xxxxxx 2007-03-30 11:11 EST ------- (In reply to comment #27) > (In reply to comment #25) > > > Some further untangling may be possible with code changes, but I don't know if > > we want that. > > > > So I'm going to fix the thesky issue and then build this. > > I think we may want this. This has merit for FlightGear (and other dependent > apps), so lets try to rework the code. If upstream barfs on it, we can pull it back. > Okay, I've "fixed" most of this I use "" because I fixed it by inlining some functions into the classes. In the sgmisc case this is harmless, in the sgprops case its less pretty. With this untangling in place the only remaining problems are: W: SimGear undefined-non-weak-symbol /usr/lib/libsgsky-0.3.10.so sgEnviro W: SimGear undefined-non-weak-symbol /usr/lib/libsgsky-0.3.10.so _ZN8SGEnviro6getFOVERfS0_ W: SimGear undefined-non-weak-symbol /usr/lib/libsgsky-0.3.10.so _ZN8SGEnviro17set_view_in_cloudEb W: SimGear undefined-non-weak-symbol /usr/lib/libsgsky-0.3.10.so _ZN8SGEnviro14callback_cloudEfffifi These are much harder to fix as sky/cloud and environment are really entangled pretty much. Anyways I've committed the current state of afairs to CVS and requested a build, since I believe this is as good as its going to get for now. As I myself am not very familiar with SimGear / Flightgear, I would like to ask you to take these patches upstream and see how they respond, good luck! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review