https://bugzilla.redhat.com/show_bug.cgi?id=1055721 --- Comment #3 from Christopher Meng <cickumqt@xxxxxxxxx> --- Still a mess...Would you like to move all subpackage above %prep? 1. BuildRequires: python-devel --> BuildRequires: python2-devel If you want to push it to EPEL, better add conditional lines but not simply revert back this change. 2. Remove unneeded: %check %clean 3. Requires(post): systemd-units Requires(preun): systemd-units Requires(postun): systemd-units PLease use modern style: https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd 4. doc subpackage should be noarch. 5. Rpmlint ------- Checking: libqpid-dispatch-0.1-1.fc21.1.i686.rpm libqpid-dispatch-devel-0.1-1.fc21.1.i686.rpm qpid-dispatch-router-0.1-1.fc21.1.i686.rpm qpid-dispatch-router-docs-0.1-1.fc21.1.i686.rpm qpid-dispatch-tools-0.1-1.fc21.1.i686.rpm qpid-dispatch-0.1-1.fc21.1.src.rpm libqpid-dispatch.i686: W: shared-lib-calls-exit /usr/lib/libqpid-dispatch.so.0.1 exit@GLIBC_2.0 libqpid-dispatch.i686: W: no-documentation libqpid-dispatch.i686: E: non-executable-script /usr/lib/qpid-dispatch/python/qpid_dispatch_internal/tools/display.py 0644L /usr/bin/env libqpid-dispatch-devel.i686: W: no-documentation qpid-dispatch-router.i686: W: invalid-url URL: http://qpid.apache.org/ timed out qpid-dispatch-router.i686: W: only-non-binary-in-usr-lib qpid-dispatch-tools.i686: W: no-manual-page-for-binary qdtest 6 packages and 0 specfiles checked; 1 errors, 6 warnings. 6. Are you the upstream? If so please patch them: *No copyright* Apache (v2.0) ---------------------------- qpid-dispatch-0.1/bin/test.sh qpid-dispatch-0.1/config.sh qpid-dispatch-0.1/include/qpid/dispatch.h qpid-dispatch-0.1/include/qpid/dispatch/agent.h qpid-dispatch-0.1/include/qpid/dispatch/alloc.h qpid-dispatch-0.1/include/qpid/dispatch/amqp.h qpid-dispatch-0.1/include/qpid/dispatch/bitmask.h qpid-dispatch-0.1/include/qpid/dispatch/buffer.h qpid-dispatch-0.1/include/qpid/dispatch/compose.h qpid-dispatch-0.1/include/qpid/dispatch/config.h qpid-dispatch-0.1/include/qpid/dispatch/container.h qpid-dispatch-0.1/include/qpid/dispatch/ctools.h qpid-dispatch-0.1/include/qpid/dispatch/dispatch.h qpid-dispatch-0.1/include/qpid/dispatch/error.h qpid-dispatch-0.1/include/qpid/dispatch/hash.h qpid-dispatch-0.1/include/qpid/dispatch/iovec.h qpid-dispatch-0.1/include/qpid/dispatch/iterator.h qpid-dispatch-0.1/include/qpid/dispatch/log.h qpid-dispatch-0.1/include/qpid/dispatch/message.h qpid-dispatch-0.1/include/qpid/dispatch/parse.h qpid-dispatch-0.1/include/qpid/dispatch/python_embedded.h qpid-dispatch-0.1/include/qpid/dispatch/router.h qpid-dispatch-0.1/include/qpid/dispatch/server.h qpid-dispatch-0.1/include/qpid/dispatch/threading.h qpid-dispatch-0.1/include/qpid/dispatch/timer.h qpid-dispatch-0.1/include/qpid/dispatch/user_fd.h qpid-dispatch-0.1/python/qpid_dispatch_internal/config/__init__.py qpid-dispatch-0.1/python/qpid_dispatch_internal/config/parser.py qpid-dispatch-0.1/python/qpid_dispatch_internal/config/schema.py qpid-dispatch-0.1/python/qpid_dispatch_internal/router/__init__.py qpid-dispatch-0.1/python/qpid_dispatch_internal/router/configuration.py qpid-dispatch-0.1/python/qpid_dispatch_internal/router/data.py qpid-dispatch-0.1/python/qpid_dispatch_internal/router/engine.py qpid-dispatch-0.1/python/qpid_dispatch_internal/router/link.py qpid-dispatch-0.1/python/qpid_dispatch_internal/router/mobile.py qpid-dispatch-0.1/python/qpid_dispatch_internal/router/neighbor.py qpid-dispatch-0.1/python/qpid_dispatch_internal/router/node.py qpid-dispatch-0.1/python/qpid_dispatch_internal/router/path.py qpid-dispatch-0.1/python/qpid_dispatch_internal/router/routing.py qpid-dispatch-0.1/python/qpid_dispatch_internal/stubs/__init__.py qpid-dispatch-0.1/python/qpid_dispatch_internal/stubs/ioadapter.py qpid-dispatch-0.1/python/qpid_dispatch_internal/stubs/logadapter.py qpid-dispatch-0.1/python/qpid_dispatch_internal/tools/__init__.py qpid-dispatch-0.1/python/qpid_dispatch_internal/tools/display.py qpid-dispatch-0.1/router/src/main.c qpid-dispatch-0.1/src/agent.c qpid-dispatch-0.1/src/alloc.c qpid-dispatch-0.1/src/alloc_private.h qpid-dispatch-0.1/src/amqp.c qpid-dispatch-0.1/src/bitmask.c qpid-dispatch-0.1/src/buffer.c qpid-dispatch-0.1/src/compose.c qpid-dispatch-0.1/src/compose_private.h qpid-dispatch-0.1/src/config.c qpid-dispatch-0.1/src/config_private.h qpid-dispatch-0.1/src/container.c qpid-dispatch-0.1/src/dispatch.c qpid-dispatch-0.1/src/dispatch_private.h qpid-dispatch-0.1/src/hash.c qpid-dispatch-0.1/src/iovec.c qpid-dispatch-0.1/src/iterator.c qpid-dispatch-0.1/src/log.c qpid-dispatch-0.1/src/log_private.h qpid-dispatch-0.1/src/message.c qpid-dispatch-0.1/src/message_private.h qpid-dispatch-0.1/src/parse.c qpid-dispatch-0.1/src/posix/threading.c qpid-dispatch-0.1/src/python_embedded.c qpid-dispatch-0.1/src/router_agent.c qpid-dispatch-0.1/src/router_node.c qpid-dispatch-0.1/src/router_private.h qpid-dispatch-0.1/src/router_pynode.c qpid-dispatch-0.1/src/server.c qpid-dispatch-0.1/src/server_private.h qpid-dispatch-0.1/src/timer.c qpid-dispatch-0.1/src/timer_private.h qpid-dispatch-0.1/src/work_queue.c qpid-dispatch-0.1/src/work_queue.h qpid-dispatch-0.1/tests/alloc_test.c qpid-dispatch-0.1/tests/compose_test.c qpid-dispatch-0.1/tests/field_test.c qpid-dispatch-0.1/tests/message_test.c qpid-dispatch-0.1/tests/parse_test.c qpid-dispatch-0.1/tests/router_engine_test.py qpid-dispatch-0.1/tests/run_unit_tests.c qpid-dispatch-0.1/tests/run_unit_tests_size.c qpid-dispatch-0.1/tests/server_test.c qpid-dispatch-0.1/tests/system_tests_one_router.py qpid-dispatch-0.1/tests/test_case.h qpid-dispatch-0.1/tests/timer_test.c qpid-dispatch-0.1/tests/tool_test.c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review