[Bug 1056460] Review Request: ssdeep - Compute context triggered piecewise hashes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1056460

Ralf Corsepius <rc040203@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #5 from Ralf Corsepius <rc040203@xxxxxxxxxx> ---
APPROVED.

2 comments:
- By removing the offending lines from configure in your *build-patch, you are
destroying configure's line numbering. If you'd comment them out instead, line
numbers would remain intact (which is useful in case of problems).

- I dislike package which install headers with fairly generic names (fuzzy.h)
directly into /usr/include, but this is just my personal preference.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]