[Bug 1002157] Review Request: randomizedtesting - Java Testing Framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1002157



--- Comment #4 from Michael Simacek <msimacek@xxxxxxxxxx> ---
There are no requires for randomizedtesting-junit4-ant besides jpackage-utils.
Its name suggest it should require at least ant and junit4, but the upstream
uses <scope>provided</scope> everywhere. This is probably not a problem for
depending packages, because if they already use it, they had to specify those
dependencies themselves. However it looks like misuse of that scope and you
could ask upstream whether they really meant it that way.


Having '%files -f .mfiles-%{name}-parent' looks error prone. It seems better to
have just '%files -f .mfiles' and use '%mvn_package :%{name}-parent'. If the
upstream ever add something into main package, you wouldn't miss it this way.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]