https://bugzilla.redhat.com/show_bug.cgi?id=1056336 Ralf Corsepius <rc040203@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rc040203@xxxxxxxxxx --- Comment #2 from Ralf Corsepius <rc040203@xxxxxxxxxx> --- Nick, I feel you just submitted a raw cpanspec generated package. Please understand, cpanspec is just a band-aid to assist perl-module packagers and does not generate clean spec. The spec-files it generates should be treated as templates and usually need manual refinement. - The subject of this BZ is incomplete. Please fill out <short summary here> - Source0: Points to a "by-modules" URL. Best-practice is to let it point to an "author"-URL. - The %description needs improvements. - Unless you also want to support CentOS, BuildRoot: ... rm -rf ${RPM_BUILD_ROOT} ... %clean ... %defattr() can be removed - Most of the explicit "Requires:" are redundant to those being automatically added by rpm and therefore should be removed. - Though the sources tells this package would require Mozilla::CA, I can't spot any place inside of the sources, whete this package actually uses it. Please check - May-be I am missing something, but I am inclined to believe this is an upstream packaging bug. - Consider to add these "BuildRequire:": perl(Carp) perl(Data::Dumper) perl(List::Util) perl(strict) perl(warnings) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review