[Bug 1056057] Review Request: dleyna-server - Service for interacting with Digital Media Servers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1056057

Kenjiro Nakayama <nakayamakenjiro@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nakayamakenjiro@xxxxxxxxx



--- Comment #1 from Kenjiro Nakayama <nakayamakenjiro@xxxxxxxxx> ---
(This is not official review.)

Hi, I am a short comment on your spec file.

I don't know why you wrote the Source0 like this.

> # This URL: https://github.com/01org/dleyna-server/archive/v%{version}.tar.gz
> # will create a dleyna-server-%{version}.tar.gz file
> Source0:        %{name}-%{version}.tar.gz

If you have your code archive on your github, shouldn't you write url like [1]?

[1] https://fedoraproject.org/wiki/Packaging:SourceURL#Github

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]