https://bugzilla.redhat.com/show_bug.cgi?id=1055108 --- Comment #2 from Denis Fateyev <denis@xxxxxxxxxxx> --- Thanks for the review, Jeff. I'd recommend you to change the review's "informal" status into the "official" ;-) (get assigned with it) > License appears to be the 4-clause BSD license with clauses 2-4 removed, not > the MIT license. Additionally, the name "JUHA PIRKOLA" appears in the > disclaimer, not Roy Keene, the listed author. Please have upstream correct the > license in freecolor.c. It would be great if they would also include a copy of > the license as a separate file. If upstream isn't willing to provide > clarification then you will need to get Legal to bless it. > Please have upstream clarify license. Completely agree with it. I notified upstream several days ago; still no answer from there. To have the manpage and separate license file included is also a good idea. As for the silent setup, I've just fixed that. Added el5-conditional for BuildRoot. Checked debuginfo package, it's valid. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review