https://bugzilla.redhat.com/show_bug.cgi?id=1053640 --- Comment #5 from Sergio Pascual <sergio.pasra@xxxxxxxxx> --- > > Issues: > ======= > - If (and only if) the source package includes the text of the license(s) in > its own file, then that file, containing the text of the license(s) for the > package is included in %doc. > Note: Cannot find COPYING in rpm(s) > Why is LICENSE.txt is removed? > See: > http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text > I remove those files because they are installed in the library directory, /usr/lib64/python2.7/site-packages/statsmodels and are redundant with the LICENSE.txt in %doc statsmodels/LICENSE.txt seems to be an older version of LICENSE.txt Anyway, I have copied it and it is in %doc with LICENSE.txt renamed as LICENSE.statsmodels.txt I will ask upstream to remove/update this file > - License file installed when any subpackage combination is installed. > Part of problem is that LICENSE.txt et. al. are removed. Another is that > the subpackages does not require the base package and thus can be installed > without license info. Either require the base package or (IMHO better) > duplicate the license files in the subpackages. The LICENSE.txt files are duplicated in %doc for pythons-statsmodels and python-statsmodels-doc > > - Package consistently uses macros (instead of hard-coded directory names). > Personally, I don't see the need for the upname macro. It just makes things > harder to read. upname is upstream name. As the python guidelines requires to preappend python- python3- to the package name (which is usually the same as the upstream name), upname is very handy > Also, since the python3 stuff isn't functional I think > it's better to remove for now, re-introducing it once it works. No > blockers. > I'm testing python3 packages of the missing dependencies. > - Add a -a option to the cp command in %build to preserve timestamps. Done > > - The find command has a '-delete' option which is somewhat cleaner. > No blocker. > Updated, thanks New SRPM and spec with the fixes mentioned above Spec URL: http://guaix.fis.ucm.es/~spr/fedora/python-statsmodels.spec SRPM URL: http://guaix.fis.ucm.es/~spr/fedora/python-statsmodels-0.5.0-5.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review