[Bug 1054867] Review Request: perl-Lingua-EN-Sentence - Module for splitting text into sentences

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1054867

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #2 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ Package build successfully in mock rawhide

- rpmlint on generated rpms gave output
perl-Lingua-EN-Sentence.noarch: W: file-not-utf8
/usr/share/doc/perl-Lingua-EN-Sentence/Changes
2 packages and 0 specfiles checked; 0 errors, 1 warnings.


+ Source verified with upstream as
upstream source =>
f886e3e9e2ddab299f80fd9f252eb48930b0bf4e1cbd1e85193d8565727e171d
srpm source => f886e3e9e2ddab299f80fd9f252eb48930b0bf4e1cbd1e85193d8565727e171d

+ License is valid and included as header in source file.

+ make test gave 
All tests successful.
Files=1, Tests=1,  0 wallclock secs ( 0.02 usr  0.01 sys +  0.02 cusr  0.00
csys =  0.05 CPU)

+ Package perl-Lingua-EN-Sentence-0.25-1.fc21.noarch =>
Provides: perl(Lingua::EN::Sentence) = 0.25 perl-Lingua-EN-Sentence =
0.25-1.fc21
Requires: perl >= 0:5.005_03 perl(Carp) perl(Exporter) perl(POSIX) perl(locale)
perl(strict) perl(vars)



Suggestions:
1) Fix the rpmlint warning of file-not-utf8 before importing this package in
Fedora.


2) Group tag is optional. You may want to remove it from spec.
APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]