https://bugzilla.redhat.com/show_bug.cgi?id=1024779 Volker Fröhlich <volker27@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |volker27@xxxxxx --- Comment #2 from Volker Fröhlich <volker27@xxxxxx> --- You can remove the defattrs. They were only necessary up to EL4. LGPLv2.1 should be LGPLv2+. "Requires: libroutermanager = %{version}" should have an isa and release macro. What is the if clause around ldconfig in the libroutermanager scriptlets good for? The plugins don't require the license files, as they can't be installed on their own. I'd leave out the whole %doc lines there. I think it's not allowed to add license files yourself. However: incorrect-fsf-address /usr/share/doc/libroutermanager/COPYING.LGPL. It's also wrong in COPYING. Upstream should correct that. Add -q to the setup macro. Does roger-router somehow conflict with ffgtk? I'm usually using _datadir instead of _datarootdir. I don't know whether one should be preferred over the other though. You could shorten the files sections like this: %files plugins-fritzfon %{_datarootdir}/glib-2.0/schemas/org.tabos.roger.plugins.fritzfon.gschema.xml %{_libdir}/roger/plugins/fritzfon/ %files ... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review