[Bug 1026252] Review Request: kluppe - a live looping instrument

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1026252

Volker Fröhlich <volker27@xxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |volker27@xxxxxx



--- Comment #1 from Volker Fröhlich <volker27@xxxxxx> ---
Build fails in Rawhide due to warnings being treated as errors.

You should use smp_mflags on make invocation.

"/builddir/build/BUILDROOT/kluppe-0.6.15-1.fc19.x86_64/usr/share/applications/kluppe.desktop:
warning: key "Encoding" in group "Desktop Entry" is deprecated
/builddir/build/BUILDROOT/kluppe-0.6.15-1.fc19.x86_64/usr/share/applications/kluppe.desktop:
hint: value item "Sequencer" in key "Categories" in group "Desktop Entry" can
be extended with another category among the following categories:
AudioVideo;Audio"

I'd suggest to use a file instead of a heredoc for the desktop file. Also
submit it upstream, if you haven't yet.

Don't label the man pages with %doc. rpmbuild takes care of that itself.

cp -rp src/frontend/kluppe/%{name}.png ... -- The r doesn't serve a purpose
there. Looking at the linking, klopfer doesn't seem to be a graphical program.
It also has no desktop file. What's the idea behind that copy command then?

On http://dieb13.klingt.org/content/projects/kluppe.html it says that kluppe
has moved to http://kluppe.klingt.org/. You should use that as the URL then.

kluppe.x86_64: E: incorrect-fsf-address
/usr/share/doc/kluppe-0.6.15/LICENSE.txt -- Contact the author if you haven't
yet.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]