https://bugzilla.redhat.com/show_bug.cgi?id=858078 --- Comment #11 from Patrick Noffke <patrick@xxxxxxxxx> --- Output of fedora-review: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. Note: mingw32-qt5-qtsvg : /usr/i686-w64-mingw32/sys- root/mingw/include/qt5/QtSvg/5.2.0/QtSvg/private/qsvgfont_p.h mingw32-qt5-qtsvg : /usr/i686-w64-mingw32/sys- root/mingw/include/qt5/QtSvg/5.2.0/QtSvg/private/qsvgfunctions_wince_p.h mingw32-qt5-qtsvg : /usr/i686-w64-mingw32/sys- root/mingw/include/qt5/QtSvg/5.2.0/QtSvg/private/qsvggraphics_p.h mingw32-qt5-qtsvg : /usr/i686-w64-mingw32/sys- root/mingw/include/qt5/QtSvg/5.2.0/QtSvg/private/qsvghandler_p.h mingw32-qt5-qtsvg : /usr/i686-w64-mingw32/sys- root/mingw/include/qt5/QtSvg/5.2.0/QtSvg/private/qsvgnode_p.h mingw32-qt5-qtsvg : /usr/i686-w64-mingw32/sys- root/mingw/include/qt5/QtSvg/5.2.0/QtSvg/private/qsvgstructure_p.h mingw32-qt5-qtsvg : /usr/i686-w64-mingw32/sys- root/mingw/include/qt5/QtSvg/5.2.0/QtSvg/private/qsvgstyle_p.h mingw32-qt5-qtsvg : /usr/i686-w64-mingw32/sys- root/mingw/include/qt5/QtSvg/5.2.0/QtSvg/private/qsvgtinydocument_p.h mingw32-qt5-qtsvg : /usr/i686-w64-mingw32/sys- root/mingw/include/qt5/QtSvg/qgraphicssvgitem.h mingw32-qt5-qtsvg : /usr/i686-w64-mingw32/sys-root/mingw/include/qt5/QtSvg/qsvggenerator.h mingw32-qt5-qtsvg : /usr/i686-w64-mingw32/sys- root/mingw/include/qt5/QtSvg/qsvgrenderer.h mingw32-qt5-qtsvg : /usr/i686-w64-mingw32/sys-root/mingw/include/qt5/QtSvg/qsvgwidget.h mingw32-qt5-qtsvg : /usr/i686-w64-mingw32/sys- root/mingw/include/qt5/QtSvg/qtsvgglobal.h mingw32-qt5-qtsvg : /usr/i686-w64-mingw32/sys-root/mingw/include/qt5/QtSvg/qtsvgversion.h mingw64-qt5-qtsvg : /usr/x86_64-w64-mingw32/sys- root/mingw/include/qt5/QtSvg/5.2.0/QtSvg/private/qsvgfont_p.h mingw64-qt5-qtsvg : /usr/x86_64-w64-mingw32/sys- root/mingw/include/qt5/QtSvg/5.2.0/QtSvg/private/qsvgfunctions_wince_p.h mingw64-qt5-qtsvg : /usr/x86_64-w64-mingw32/sys- root/mingw/include/qt5/QtSvg/5.2.0/QtSvg/private/qsvggraphics_p.h mingw64-qt5-qtsvg : /usr/x86_64-w64-mingw32/sys- root/mingw/include/qt5/QtSvg/5.2.0/QtSvg/private/qsvghandler_p.h mingw64-qt5-qtsvg : /usr/x86_64-w64-mingw32/sys- root/mingw/include/qt5/QtSvg/5.2.0/QtSvg/private/qsvgnode_p.h mingw64-qt5-qtsvg : /usr/x86_64-w64-mingw32/sys- root/mingw/include/qt5/QtSvg/5.2.0/QtSvg/private/qsvgstructure_p.h mingw64-qt5-qtsvg : /usr/x86_64-w64-mingw32/sys- root/mingw/include/qt5/QtSvg/5.2.0/QtSvg/private/qsvgstyle_p.h mingw64-qt5-qtsvg : /usr/x86_64-w64-mingw32/sys- root/mingw/include/qt5/QtSvg/5.2.0/QtSvg/private/qsvgtinydocument_p.h mingw64-qt5-qtsvg : /usr/x86_64-w64-mingw32/sys- root/mingw/include/qt5/QtSvg/qgraphicssvgitem.h mingw64-qt5-qtsvg : /usr/x86_64-w64-mingw32/sys-root/mingw/include/qt5/QtSvg/qsvggenerator.h mingw64-qt5-qtsvg : /usr/x86_64-w64-mingw32/sys- root/mingw/include/qt5/QtSvg/qsvgrenderer.h mingw64-qt5-qtsvg : /usr/x86_64-w64-mingw32/sys-root/mingw/include/qt5/QtSvg/qsvgwidget.h mingw64-qt5-qtsvg : /usr/x86_64-w64-mingw32/sys- root/mingw/include/qt5/QtSvg/qtsvgglobal.h mingw64-qt5-qtsvg : /usr/x86_64-w64-mingw32/sys-root/mingw/include/qt5/QtSvg/qtsvgversion.h See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: mingw32-qt5-qtsvg, mingw64-qt5-qtsvg. Illegal package name: mingw32-qt5-qtsvg, mingw64-qt5-qtsvg. Does not provide -static: mingw32-qt5-qtsvg, mingw64-qt5-qtsvg. See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries ===== MUST items ===== Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [X]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "BSD (3 clause) MIT/X11 (BSD like)", "Unknown or generated". 68 files have unknown license. Detailed output of licensecheck in /home/pnoffke/projects/fedora/mingw-qt5-qtsvg/858078 -mingw-qt5-qtsvg/licensecheck.txt [X]: License file installed when any subpackage combination is installed. [X]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/i686-w64-mingw32/sys- root/mingw/lib/qt5/plugins/iconengines, /usr/x86_64-w64-mingw32/sys- root/mingw/lib/qt5/plugins/iconengines [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/x86_64-w64-mingw32/sys- root/mingw/lib/qt5/plugins/iconengines, /usr/i686-w64-mingw32/sys- root/mingw/lib/qt5/plugins/iconengines [X]: Package contains no bundled libraries without FPC exception. [X]: Changelog in prescribed format. [X]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [X]: Package uses nothing in %doc for runtime. [X]: Package consistently uses macros (instead of hard-coded directory names). [X]: Package is named according to the Package Naming Guidelines. [X]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [X]: Requires correct, justified where necessary. [X]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [X]: Package is not known to require an ExcludeArch tag. [X]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 184320 bytes in 8 files. [X]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mingw32-qt5-qtsvg , mingw64-qt5-qtsvg [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: The placement of pkgconfig(.pc) files are correct. Note: mingw64-qt5-qtsvg : /usr/x86_64-w64-mingw32/sys- root/mingw/lib/pkgconfig/Qt5Svg.pc mingw32-qt5-qtsvg : /usr/i686-w64-mingw32/sys-root/mingw/lib/pkgconfig/Qt5Svg.pc [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: mingw32-qt5-qtsvg-5.2.0-1.fc21.noarch.rpm mingw64-qt5-qtsvg-5.2.0-1.fc21.noarch.rpm mingw-qt5-qtsvg-5.2.0-1.fc21.src.rpm mingw-qt5-qtsvg.src:29: W: macro-in-comment %{qt_module} mingw-qt5-qtsvg.src:29: W: macro-in-comment %{snapshot_rev} mingw-qt5-qtsvg.src:29: W: macro-in-comment %{qt_module} mingw-qt5-qtsvg.src:29: W: macro-in-comment %{snapshot_rev} 3 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint mingw64-qt5-qtsvg mingw32-qt5-qtsvg 2 packages and 0 specfiles checked; 0 errors, 0 warnings. # echo 'rpmlint-done:' Requires -------- mingw64-qt5-qtsvg (rpmlib, GLIBC filtered): mingw64(kernel32.dll) mingw64(libstdc++-6.dll) mingw64(msvcrt.dll) mingw64(qt5core.dll) mingw64(qt5gui.dll) mingw64(qt5svg.dll) mingw64(qt5widgets.dll) mingw64(zlib1.dll) mingw64-crt mingw64-filesystem mingw64-pkg-config mingw32-qt5-qtsvg (rpmlib, GLIBC filtered): mingw32(kernel32.dll) mingw32(libstdc++-6.dll) mingw32(msvcrt.dll) mingw32(qt5core.dll) mingw32(qt5gui.dll) mingw32(qt5svg.dll) mingw32(qt5widgets.dll) mingw32(zlib1.dll) mingw32-crt mingw32-filesystem mingw32-pkg-config Provides -------- mingw64-qt5-qtsvg: mingw64(qsvg.dll) mingw64(qsvgicon.dll) mingw64(qt5svg.dll) mingw64-qt5-qtsvg mingw32-qt5-qtsvg: mingw32(qsvg.dll) mingw32(qsvgicon.dll) mingw32(qt5svg.dll) mingw32-qt5-qtsvg Source checksums ---------------- http://download.qt-project.org/official_releases/qt/5.2/5.2.0/submodules/qtsvg-opensource-src-5.2.0.tar.xz : CHECKSUM(SHA256) this package : bad23ebcebf8e91cc727b229a3f87f95829edfd2a7653d47e97b154aac687c59 CHECKSUM(SHA256) upstream package : bad23ebcebf8e91cc727b229a3f87f95829edfd2a7653d47e97b154aac687c59 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 858078 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG Would listing the directories (/usr/i686-w64-mingw32/sys-root/mingw/lib/qt5/plugins/iconengines, /usr/x86_64-w64-mingw32/sys-root/mingw/lib/qt5/plugins/iconengines) under the %files section in the spec remove the "ownership" message in the MUST items above? Only the file within that directory is listed. I'm guessing it doesn't complain about the imageformats directory (or others) since those are owned by other packages, but it appears the svg package is the first one to put a file in the iconengines directory. Also, is there any way to get it to not complain about the header files not being in a -devel package? This rule (to put headers in -devel) doesn't really apply to the mingw packages. Same thing for the .a files. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review