https://bugzilla.redhat.com/show_bug.cgi?id=1048493 --- Comment #8 from Antonio Trande <anto.trande@xxxxxxxxx> --- (In reply to Denis Fateyev from comment #5) > > ---------------------------- > Now review notes: > > Koji scratch builds used: > https://koji.fedoraproject.org/koji/taskinfo?taskID=6390515 (Fedora 19) > https://koji.fedoraproject.org/koji/taskinfo?taskID=6390802 (Rawhide) > > 1) Still unsure about License tag: probably, this format in spec is allowed, > but I'm unsure. Marked as "non-evaluated" for now, it requires more > clarification. "Firefox" and "xulrunner" both use simplified tag; > > 2) "Package contains no bundled libraries without FPC exception" - have no > idea whether it's actual here, could you check them, or clear the issue > providing more details? I've tried to remove some of them. However it seems to me that some sources from third cannot be cancelled without break the compilation (for example, there is not any build config option to use libvorbis system libraries; this happens for xulrunner currently built in Fedora as well). > > 3) Multiple issues with "%{mozappdir}" should be sorted; > > 4) Why not to use "xulrunner" already packaged in Fedora? To avoid possible incompatibilities between xulrunner in Fedora and Icecat in future. Spec URL: http://sagitter.fedorapeople.org/Icecat/icecat.spec SRPM URL: http://sagitter.fedorapeople.org/Icecat/icecat-24.0-3.fc20.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6409801 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review