https://bugzilla.redhat.com/show_bug.cgi?id=1049557 Matthew Miller <mattdm@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mattdm@xxxxxxxxxx --- Comment #5 from Matthew Miller <mattdm@xxxxxxxxxx> --- Funny, I was just thinking it'd be handy to have this packaged up. I'll let Igor finish the official review but throw in a few comments. It's not a big deal but I'd like to see more descriptive Summary -- something that mentions the error-checking capability, since we have a number of other utilities which do the listing and none that do the checking. I'd also suggest sneaking '.jpg' into the summary so that comes up in people's searches. Summary: Error-check and generate informative listings from JPEG files %description Jpeginfo prints information and tests integrity of JPEG/JFIF files. It can generate informative listings of .jpg files, and can also be used to test them for errors (and optionally delete broken files). or so. The license should be License: GPLv2+ since it includes the "or later" clause. I think we're missing some buildrequires, aren't we? BuildRequires: libjpeg-devel I don't think that there's any reason to remove the getopt files, but it also doesn't hurt. The idea is just to make sure that some glitch in the build process doesn't accidentally use those instead of the proper system version. There is an md5 copylib, which has an automatic extension but which should be noted -- see https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries -- which says to do: Provides: bundled(md5-plumb) (In this case, since it's the Colin Plumb code.) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review