https://bugzilla.redhat.com/show_bug.cgi?id=1052060 Ralf Corsepius <rc040203@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rc040203@xxxxxxxxxx --- Comment #3 from Ralf Corsepius <rc040203@xxxxxxxxxx> --- (In reply to Chris Lim from comment #2) > Please review again. I see your URL:'s are pointing to upstream - So are you upstream? Some remarks on your package: * Source0:-URL should be an URL pointing to upstream (Source0: www.ip2location.com/downloads/ip2location-c_6.0.2.tar.gz) * The *.spec file name does not match Fedora's conventions (Must be ip2location-c.spec, not ...-<version>. spec) * The upstream tarball is a mess. - It contains binaries and temporary files which should not be part of a source-tarball. In case you're upstream, I'd recommend you to build tarballs with "make dist", which should automatically take care about this issue. In case you're not upstream, remove all of these in %prep. - Many files carry bogus permissions. In case you're upstream, please fix them. In case you're not please fix them in %prep. * libIP2Location.so isn't properly versioned (keyword: SONAME). In case you're upstream, please change this. In case you're not, please add an SONAME 0.0.0 to the package. * Your spec is trying to build and ship a static libs. Please append --disable-static to %configure to suppress this behavior. * Please split your package into a *-devel and a run-time package. * You are trying to ship a *.la. This is not allowed in Fedora. Please rm -f this file in %install * Your spec doesn't honor multilibs correctly (Carries hard-coded refs to /usr/lib). Replace references to /usr/lib with %{_libdir}. * Supplying a file named /usr/include/imath.h seems a pretty bad idea to me, because the name seems too generic to me. I'd recommend upstream to either use a more unique/less likely to conflict name. Alternatively, a Fedora packager could install all of this package's headers into a subdir of /usr/include (e.g. /usr/include/IP2Loc; %configure --includedir=%{_includedir}/IP2Loc) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review