https://bugzilla.redhat.com/show_bug.cgi?id=1051753 Shawn Iwinski <shawn.iwinski@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |peter.borsa@xxxxxxxxx Flags| |needinfo?(peter.borsa@gmail | |.com) --- Comment #4 from Shawn Iwinski <shawn.iwinski@xxxxxxxxx> --- [x]: Package consistently uses macros (instead of hard-coded directory names). Since you define the "prerelease" global, instead of 0.1.beta1%{?dist} should use 0.1.%{prerelease}%{?dist} [!]: Requires correct, justified where necessary. Instead of Requires: php >= 5.3 need to use Requires: php-common >= 5.3 (see https://fedoraproject.org/wiki/Packaging:PHP#Requiring_a_Minimum_PHP_version) (side note: if not packaging for EPEL5 "php(language)" would be used) According to phpcompatinfo (version 2.26.0), need to add the following: # phpcompatinfo (computed from version 4.0-beta1) Requires: php-date Requires: php-mbstring Requires: php-pcre Requires: php-pdo Requires: php-pecl(zip) Requires: php-session (see https://fedoraproject.org/wiki/Packaging:PHP#Extensions_Requires) Only the requires is a blocker. The macro usage one is just a "should" note. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review