[Bug 977638] Review Request: python-espeak - Python bindings for espeak

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=977638



--- Comment #19 from Eduardo Echeverria <echevemaster@xxxxxxxxx> ---
Hi @eduardo.
- take into account that macros in comments and changelogs must be escaped- use
two '%'s to escape them. i.e. 
* Sat Jul 20 2013 Eduardo Mayorga Téllez <mayorga@xxxxxxxxxxxxxxxxx> - 0.4-5
- Remove %%fdupes macro
- Use %%{name} macro in Source tag 

- I don't see any removed egg-file on %prep- i.e
%setup -q -n %{pkgname}-%{version}
# Remove bundled egg-info
rm -rf python-espeak.egg-info

- Please fix the permissions of
/usr/lib64/python2.7/site-packages/espeak/core.so
chmod 755 probably can be fix the problem

- @ciku i can't see any reference to use %python2_sitearch in
http://fedoraproject.org/wiki/Packaging:Python#Macros. just advised the use of
%{_python2}

- please delete the Ctrl+R ('LEFT-TO-RIGHT MARK' (U+200E)) of the url, because
that you are obtaining a wrong url in rpmlint

- the spec that you paste on the review must be the same of you have in SRPM,
please fix.

Diff spec file in url and in SRPM
---------------------------------
---
/home/echevemaster/test-packages-fedora/977638-python-espeak/srpm/python-espeak.spec
       2014-01-14 22:01:33.793797415 -0430
+++
/home/echevemaster/test-packages-fedora/977638-python-espeak/srpm-unpacked/python-espeak.spec
      2014-01-14 14:41:16.000000000 -0430
@@ -5,5 +5,5 @@

 License:        GPLv3+
-URL:            https://launchpad.net/python-espeak
+URL:            https://launchpad.net/python-espeak<U+200E>
 Source0:       
http://launchpad.net/%{name}/trunk/%{version}/+download/%{name}-%{version}.tar.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]