https://bugzilla.redhat.com/show_bug.cgi?id=1052040 Petr Šabata <psabata@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |psabata@xxxxxxxxxx --- Comment #15 from Petr Šabata <psabata@xxxxxxxxxx> --- (In reply to Mohammed Isam from comment #12) > I don't want to sound dumb, but this is my first package you know.. so what > can I change in the spec file to start with? Please, go through the Fedora Packaging Guidelines: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines It's a fairly long document with many specific rules for various SIGs (Special Interest Groups). It will take a few packages until you get comfortable with all that. What you need to change in your package now is: 1. Don't use ExclusiveArch or BuildArch unless there's a reason for it. Your code seems to run on non-i686 too and if it breaks on some arches, you should fix the code rather than excluding those. 2. There's a list of packages that are always present in the buildroot and hence don't need to be explicitly listed in your BuildRequires even if you use them: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Exceptions_2 You see coreutils is there (plus your SPEC file doesn't use it anyway). Drop that build-time dependency. 3. Your package doesn't appear to use coreutils at runtime either, therefore the Requires: coreutils is also unneeded. Drop it. 4. On the other hand, you use cmake to build your application. cmake is not a part of the base buildroot and needs to be BuildRequire'd. 5. Consider writing a manpage. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review