Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: samba https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226387 ------- Additional Comments From dmitry@xxxxxxxxxxxx 2007-03-29 12:41 EST ------- > not everything is GPL, is there a way to represent this? AFAIK, things like "GPL, MIT" are used (I saw it in some Extras packages) > Why did you remove the (pre) for samba-common Requires? I had removed (pre) for "samba" requires, since "samba" package has no any "%pre" section... > libtool If not used, then return back "Requires: autoconf" :) > Just drop the -static and never ship the libsmbclient.a library ? Yes, exactly. > cosmetic changes OK :) But cosmetic changes seem to be needed, at least for readability. I can check in CVS too, just report me when some changes will be made. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review