https://bugzilla.redhat.com/show_bug.cgi?id=1052524 --- Comment #2 from Henrik Hodne <henrik@xxxxxxxx> --- Thank you! Replies are in-line below: > 1. Why is the test suite not run in %check? > 2. LICENSE should be marked as %doc. > 3. I recommend moving README.md out of the -doc subpackage and into the main package. Fixed, fixed and moved. > 4. I recommend excluding Rakefile, Gemfile, and %{gem_instdir}/redcard.gemspec. > > For example, immediately after %gem_install, I usually insert the following "rm" command: > > ... > > %gem_install > > # Remove unnecessary gemspec file > rm .%{gem_instdir}/%{gem_name}.gemspec I marked them as %exclude now. I can rm them instead if you think that is better? > 5. gem2rpm leaves trailing whitespace on a couple lines. Please remove this. Where are you seeing trailing whitespaces? I couldn't find any in the spec file. I uploaded the new spec and SRPM in the same location as listed above. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review