Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: bsh https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225628 Jochen@xxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|mwringe@xxxxxxxxxx |Jochen@xxxxxxxxxxxxxxx Flag| |fedora-review? ------- Additional Comments From Jochen@xxxxxxxxxxxxxxx 2007-03-29 12:17 EST ------- Good: + Local build works fine. * Binaries packages are ok. + License ok. + naming seems ok. Bad: - Rpmlint have warnings on source package: W: bsh non-standard-group Development/Java W: bsh strange-permission bsh-1.3.0-src.tar.bz2 0660 W: bsh strange-permission bsh.spec 0660 W: bsh strange-permission bsh-build.patch 0660 - Unnecceasry BR uildRequires: perl should not be included (wiki: Packaging/Guidelines#Exceptions) - Surce0 doesn't contains a full-qualified URL -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review