https://bugzilla.redhat.com/show_bug.cgi?id=1051901 --- Comment #2 from Vít Ondruch <vondruch@xxxxxxxxxx> --- * %clean may not be required - %clean is required just for EPEL5 [1], are you planning to submit this package for EPEL5? Make this section optional just for EPEL5 might be good idea as well. Not a blocker though. * License file in main package - The license file have to be shipped in the main package [2]. * Wrong conditionalized ruby requires - "%if 0%{?rhel} <= 6" is on Fedora always true, since %{rhel} macro is not defined. This results in "Error: No Package found for ruby(abi) = 1.8" during build. * BuildRequires: ruby - There is no need for "BuildRequires: ruby" as long as the gem is noarch. "BuildRequires: ruby(release)" should be enough. * Move test and Rakefile into -doc subpackage - Files which are not needed for runtime are typically placed into -doc subpackage. [1] https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean [2] https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review