[Bug 1051738] Review Request: mkbrutus - Password bruteforcer for MikroTik devices or boxes running RouterOS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1051738



--- Comment #5 from Tonet Jallo <tonet666p@xxxxxxxxx> ---
The upstreams name is MKBRUTUS, i will change the spec file name, mkbrutus is
programed in Python 3 so depends on python3, i don't undestand you say about
licence, AGPLv3 is here
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing.

Thanks for your recomendations, i will fix now, greetings

(In reply to Michael Schwendt from comment #3)
> This is just a brief look at the spec/src.rpm, since the ticket description
> was unusual.
> 
> 
> Spec file name and %{name} differ in case.
> https://fedoraproject.org/wiki/Packaging:NamingGuidelines#General_Naming
> 
> 
> > BuildRequires:  python3-devel
> 
> Why? %build is empty.
> 
> 
> > License:        AGPLv3
> 
> That doesn't match the included files.
> https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#.
> 22or_later_version.22_licenses
> 
> 
> > Patch0:		command-mode.patch
> 
> This renames the executable. It keeps "env" in the shebang. It changes
> "python" into "python3", but the package doesn't depend on Python 3.
> 
> https://fedoraproject.org/wiki/Packaging:
> Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment
> 
> 
> > %files
> 
> https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text
> 
> 
> Please check out the "fedora-review" tool and the 
> https://fedoraproject.org/wiki/Packaging:ReviewGuidelines page, especially
> when submitting a package for review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]