[Bug 1051920] Review Request: udisks2-lvm - LVM DBus add-on for udisks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1051920



--- Comment #2 from Jamie Nguyen <jamielinux@xxxxxxxxxxxxxxxxx> ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


===== ISSUES =====

[!]: If the package is under multiple licenses, the licensing breakdown must
     be documented in the spec.

Perhaps add a comment like this above the License field:
"The daemon and tools are licensed under the GPLv2 (or later) and libraries are
licensed under LGPLv2 (or later)."


udisks2-lvm.x86_64: E: incorrect-fsf-address
/usr/share/dbus-1/interfaces/com.redhat.lvm2.xml

Patch and inform upstream.


udisks2-lvm.x86_64: W: non-conffile-in-etc
/etc/dbus-1/system.d/com.redhat.lvm2.conf

Mark as configuration file.



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "LGPL (v2.1 or later)", "LGPL", "GPL (v2 or later)". Detailed output of
     licensecheck in /home/mockbuild/udisks2-lvm/licensecheck.txt
[!]: If the package is under multiple licenses, the licensing breakdown must
     be documented in the spec.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/udisks2
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 61440 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.


Rpmlint
-------
Checking: udisks2-lvm-0.1-0.1.590423bgit.fc21.x86_64.rpm
          udisks2-lvm-0.1-0.1.590423bgit.fc21.src.rpm
udisks2-lvm.x86_64: E: explicit-lib-dependency libudisks2
udisks2-lvm.x86_64: W: spelling-error Summary(en_US) udisks -> disks, u disks,
Saudis
udisks2-lvm.x86_64: W: spelling-error %description -l en_US udisks -> disks, u
disks, Saudis
udisks2-lvm.x86_64: W: spelling-error %description -l en_US addon -> ad don,
ad-don, add on
udisks2-lvm.x86_64: E: incorrect-fsf-address
/usr/share/dbus-1/interfaces/com.redhat.lvm2.xml
udisks2-lvm.x86_64: W: non-conffile-in-etc
/etc/dbus-1/system.d/com.redhat.lvm2.conf
udisks2-lvm.src: W: spelling-error Summary(en_US) udisks -> disks, u disks,
Saudis
udisks2-lvm.src: W: spelling-error %description -l en_US udisks -> disks, u
disks, Saudis
udisks2-lvm.src: W: spelling-error %description -l en_US addon -> ad don,
ad-don, add on
udisks2-lvm.src:52: E: hardcoded-library-path in
%{_prefix}/lib/systemd/system/udisks-lvm.service
udisks2-lvm.src:53: E: hardcoded-library-path in
/usr/lib/udisks2/udisks-lvm-helper
udisks2-lvm.src:54: E: hardcoded-library-path in /usr/lib/udisks2/udisksd-lvm
udisks2-lvm.src: W: invalid-url Source0: udisks2-lvm-590423b.tar.gz
2 packages and 0 specfiles checked; 5 errors, 8 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint udisks2-lvm
udisks2-lvm.x86_64: E: explicit-lib-dependency libudisks2
udisks2-lvm.x86_64: W: spelling-error Summary(en_US) udisks -> disks, u disks,
Saudis
udisks2-lvm.x86_64: W: spelling-error %description -l en_US udisks -> disks, u
disks, Saudis
udisks2-lvm.x86_64: W: spelling-error %description -l en_US addon -> ad don,
ad-don, add on
udisks2-lvm.x86_64: E: incorrect-fsf-address
/usr/share/dbus-1/interfaces/com.redhat.lvm2.xml
udisks2-lvm.x86_64: W: non-conffile-in-etc
/etc/dbus-1/system.d/com.redhat.lvm2.conf
1 packages and 0 specfiles checked; 2 errors, 4 warnings.
# echo 'rpmlint-done:'



Requires
--------
udisks2-lvm (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libgio-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgudev-1.0.so.0()(64bit)
    liblvm2app.so.2.2()(64bit)
    liblvm2app.so.2.2(Base)(64bit)
    libpolkit-gobject-1.so.0()(64bit)
    libpthread.so.0()(64bit)
    libudisks2
    libudisks2.so.0()(64bit)
    rtld(GNU_HASH)



Provides
--------
udisks2-lvm:
    udisks2-lvm
    udisks2-lvm(x86-64)



Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/bin/fedora-review -m fedora-rawhide-x86_64 -r -n
review/udisks2-lvm-0.1-0.1.590423bgit.fc20.src.rpm
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]