[Bug 988648] Review Request: libunity - Unity instrumenting and integration library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=988648



--- Comment #1 from Michael Schwendt <bugs.michael@xxxxxxx> ---
Spec URL: http://cicku.me/libunity.spec
SRPM URL: http://cicku.me/libunity-6.12.0-1.fc20.src.rpm


Just a brief look at the spec:

> Summary:        Unity instrumenting and integration library

Somewhat pedantic, but I only took a look at this ticket because I wanted to
know whether "Unity" here is ambiguous. More clear would be

  Summary: Instrumenting and integration library for the Unity shell

IMO.


> %package        devel
> Requires:       %{name} = %{version}-%{release}

https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package


> %package -n     python-%{name}
> Summary:        Python bindings for libunity

Note that the "Requiring Base Package" guidelines are not specific to -devel
packages.


> %files
> %{_libdir}/girepository-1.0/*.typelib
> %{_libdir}/libunity.so.*
> %{_libdir}/libunity/libunity-protocol-private.so.*

Which package owns %{_libdir}/libunity/?

> %files devel
> %{_libdir}/libunity/libunity-protocol-private.so

Please verify how/when this lib is used. Judging based on its path it seems to
be a private plugin/extension lib, which is dlopen()'ed at runtime. Verify
whether libunity loads it via the non-versioned *.so name or the versioned one.
In that case, this file may need to be moved into the correct package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]