https://bugzilla.redhat.com/show_bug.cgi?id=948753 Shawn Iwinski <shawn.iwinski@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Shawn Iwinski <shawn.iwinski@xxxxxxxxx> --- [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [!]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [!]: Buildroot is not present Note: Buildroot: present but not needed [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required Remove EPEL5 bits after initial import. [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM Acceptable diff. Diff spec file in url and in SRPM --------------------------------- --- /home/siwinski/projects/fedora/reviews/970930-php-horde-Horde-HashTable/srpm/php-horde-Horde-HashTable.spec 2014-01-11 09:09:28.860000000 -0500 +++ /home/siwinski/projects/fedora/reviews/970930-php-horde-Horde-HashTable/srpm-unpacked/php-horde-Horde-HashTable.spec 2013-07-25 04:52:58.000000000 -0400 @@ -1,5 +1,5 @@ # spec file for php-horde-Horde-HashTable # -# Copyright (c) 2013-2014 Remi Collet +# Copyright (c) 2013 Remi Collet # License: CC-BY-SA # http://creativecommons.org/licenses/by-sa/3.0/ No blockers. ===== APPROVED ===== -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review