https://bugzilla.redhat.com/show_bug.cgi?id=1051254 --- Comment #2 from Sergio Pascual <sergio.pasra@xxxxxxxxx> --- (In reply to Michael Scherer from comment #1) > > Issues: > ======= > - Large documentation must go in a -doc subpackage. Large could be size > (~1MB) > or number of files. > Note: Documentation size is 2007040 bytes in 156 files. > See: > http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation I have created a doc subpackage > - License should be BSD or Python software license, if I am not wrong, > see LICENSE.txt As part of the code is under Python license and the rest is under BSD the license field is "BSD and Python". I have updated the license field. > - please signal to upstrat to add COPYING file if they refer to it in the > header > ( not blocking for the review ) Done, https://github.com/pydata/patsy/issues/33 > - rm -Rf %buildroot is not needed. Not blocking, but better be clean Done > - the patch is IMHO useful for upstream, please send it and add > the link to the PR in the spec ( not blocking ) I copied the fix from upstream, actually Spec URL: http://guaix.fis.ucm.es/~spr/fedora/python-patsy.spec SRPM URL: http://guaix.fis.ucm.es/~spr/fedora/python-patsy-0.2.1-2.fc21.src.rpm BTW, I proposed a review swap for this package in the devel list. So if you want me to review a package of yours or something you are interested in, just let me know -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review