https://bugzilla.redhat.com/show_bug.cgi?id=1051738 Michael Schwendt <bugs.michael@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: MKBRUTUS - |Review Request: mkbrutus - |Mikrotik API bruteforcer |Password bruteforcer for | |MikroTik devices or boxes | |running RouterOS --- Comment #3 from Michael Schwendt <bugs.michael@xxxxxxx> --- This is just a brief look at the spec/src.rpm, since the ticket description was unusual. Spec file name and %{name} differ in case. https://fedoraproject.org/wiki/Packaging:NamingGuidelines#General_Naming > BuildRequires: python3-devel Why? %build is empty. > License: AGPLv3 That doesn't match the included files. https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#.22or_later_version.22_licenses > Patch0: command-mode.patch This renames the executable. It keeps "env" in the shebang. It changes "python" into "python3", but the package doesn't depend on Python 3. https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment > %files https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text Please check out the "fedora-review" tool and the https://fedoraproject.org/wiki/Packaging:ReviewGuidelines page, especially when submitting a package for review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review