https://bugzilla.redhat.com/show_bug.cgi?id=1049551 Antonio Trande <anto.trande@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Antonio Trande <anto.trande@xxxxxxxxx> --- (In reply to Denis Fateyev from comment #2) > Thanks for the review. > > > Please, fix these directories > > %{buildroot}/%{_bindir}/jpegoptim > > %{buildroot}/%{_mandir}/man1/jpegoptim.1 > > there is an extra slash. > > Right, but it also helps to split the path visually ;) I'm aware of extra > slashes but use them since there is no explicit prohibition in guidelines. Okay. > > > I don't know if you already know that your package is not built > > in epel5 because of old MD5 used. > > Thanks for the reminder, it's related to an old MD5 checking bug existing in > RHEL5. I think it won't affect "fedpkg build" since it imports only source > files into Git unlike "koji" which builds packages from SRPMs. It was just to be more clear possible. Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review