Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-XML-DOM-XPath - Perl extension to add XPath support to XML::DOM, using XML::XPath engine Alias: perl-XML-DOM-XPath https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233846 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-03-29 03:22 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 276b4863d2886df313f849b329b9e090 XML-DOM-XPath-0.13.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/1...................................ok t/pod.................................ok t/pod_coverage........................ok t/test_bugs...........................ok t/test_non_ascii......................ok t/test_xml_xpath_and_xml_dom_xpath....ok Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 276b4863d2886df313f849b329b9e090 XML-DOM-XPath-0.13.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/1...................................ok t/pod.................................ok t/pod_coverage........................ok t/test_bugs...........................ok t/test_non_ascii......................ok t/test_xml_xpath_and_xml_dom_xpath....ok t/test_non_ascii......................ok t/test_xml_xpath_and_xml_dom_xpath....ok t/xmlxpath_01basic....................ok t/xmlxpath_02descendant...............ok t/xmlxpath_03star.....................ok t/xmlxpath_04pos......................ok t/xmlxpath_05attrib...................ok t/xmlxpath_06attrib_val...............ok t/xmlxpath_07count....................ok t/xmlxpath_08name.....................ok t/xmlxpath_09a_string_length..........ok t/xmlxpath_09string_length............ok t/xmlxpath_10pipe.....................ok t/xmlxpath_12axisdescendant...........ok t/xmlxpath_13axisparent...............ok t/xmlxpath_14axisancestor.............ok t/xmlxpath_15axisfol_sib..............ok t/xmlxpath_16axisprec_sib.............ok t/xmlxpath_17axisfollowing............ok t/xmlxpath_18axispreceding............ok t/xmlxpath_19axisd_or_s...............ok t/xmlxpath_20axisa_or_s...............ok t/xmlxpath_21allnodes.................ok t/xmlxpath_22name_select..............ok t/xmlxpath_23func.....................ok t/xmlxpath_24namespaces...............ok t/xmlxpath_25scope....................ok t/xmlxpath_26predicate................ok t/xmlxpath_28ancestor2................ok t/xmlxpath_29desc_with_predicate......ok t/xmlxpath_30lang.....................ok All tests successful. Files=35, Tests=182, 10 wallclock secs ( 6.39 cusr + 0.85 csys = 7.24 CPU) + Provides: perl(XML::DOM::Attr) perl(XML::DOM::Comment) perl(XML::DOM::Document) perl(XML::DOM::Element) perl(XML::DOM::Namespace) perl(XML::DOM::Node) perl(XML::DOM::ProcessingInstruction) perl(XML::DOM::Text) perl(XML::DOM::XPath) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review