Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tuxpuck - Airhockey with a twist https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234307 ------- Additional Comments From j.w.r.degoede@xxxxxx 2007-03-29 00:55 EST ------- (In reply to comment #1) > Needs work: > * Missing SMP flags. If it doesn't build with it, please add a comment > (wiki: Packaging/Guidelines#parallelmake) I deliberately removed them comment added > * Desktop file: the Categories tag should not contain X-Fedora any more > (wiki: Packaging/Guidelines#desktop) Copy/paste error, removed. > * The pacakge should BuildRequire ImageMagick, and not Require it Oops, fixed > * The desktop-file spec requires at least a 48x48 icon, please generate one of > this size too I've re-read the freedesktop.org standard on this, and it says: "you should install a 48x48 icon in the hicolor theme". Notice the _should_, also the specified lookup algorithm will select the closest icon of a different size and scale that in software, I see no use in installing a prescaled icon, this won't be of any better quality then one scaled on the fly. New version with the above items fixed here: Spec URL: http://people.atrpms.net/~hdegoede/tuxpuck.spec SRPM URL: http://people.atrpms.net/~hdegoede/tuxpuck-0.8.2-2.fc7.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review