[Bug 1050744] Review Request: belle-sip - Linphone SIP stack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1050744

Christopher Meng <cickumqt@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?



--- Comment #3 from Christopher Meng <cickumqt@xxxxxxxxx> ---
1. In -devel, should be:

Requires:    %{name}%{?_isa} = %{version}-%{release}

2. autoreconf -i -f --> autoreconf -fiv

3. Hint: find %{buildroot} -name '*.la' -exec rm -f {} ';'

-->

find %{buildroot} -name '*.la' -delete


4. From your koji log:

  CC       libbellesip_la-clock_gettime.lo
  CC       libbellesip_la-port.lo
  CC       libbellesip_la-belle_sip_headers_impl.lo
  CC       libbellesip_la-belle_sip_uri_impl.lo
  CC       libbellesip_la-belle_sip_utils.lo
  CC       libbellesip_la-belle_sip_object.lo
  CC       libbellesip_la-belle_sip_loop.lo
  CC       libbellesip_la-belle_sip_resolver.lo
  CC       libbellesip_la-belle_sip_parameters.lo
  CC       libbellesip_la-belle_sdp_impl.lo
  CC       libbellesip_la-transaction.lo
  CC       libbellesip_la-listeningpoint.lo
  CC       libbellesip_la-sipstack.lo
  CC       libbellesip_la-provider.lo
  CC       libbellesip_la-channel.lo
  CC       libbellesip_la-message.lo
  CC       libbellesip_la-md5.lo
  CC       libbellesip_la-auth_helper.lo
  CC       libbellesip_la-siplistener.lo
  CC       libbellesip_la-ict.lo
  CC       libbellesip_la-ist.lo
  CC       libbellesip_la-nict.lo
  CC       libbellesip_la-nist.lo
  CC       libbellesip_la-dialog.lo
  CC       libbellesip_la-auth_event.lo
  CC       libbellesip_la-udp_listeningpoint.lo
  CC       libbellesip_la-udp_channel.lo
  CC       libbellesip_la-stream_channel.lo
  CC       libbellesip_la-stream_listeningpoint.lo
  CC       libbellesip_la-refresher.lo
  CC       libbellesip_la-dns.lo
  CC       libbellesip_la-belle_sip_dict.lo
  CC       libbellesip_generated_la-belle_sip_messageParser.lo
  CC       libbellesip_generated_la-belle_sip_messageLexer.lo
  CC       libbellesip_generated_la-belle_sdpParser.lo

Well, it's better to not use silent build so we can find if there has any
problem during building, thus appending "--disable-silent-rules" to %configure
is needed.

5. Notify upstream about the rpmlint error:

E: incorrect-fsf-address /usr/share/doc/belle-sip/COPYING

6. Licensecheck:


BSD (3 clause)
--------------
belle-sip-1.2.4/src/clock_gettime.c

GPL (v2 or later)
-----------------
belle-sip-1.2.4/include/belle-sip/auth-helper.h
belle-sip-1.2.4/include/belle-sip/belle-sdp.h
belle-sip-1.2.4/include/belle-sip/dialog.h
belle-sip-1.2.4/include/belle-sip/list.h
belle-sip-1.2.4/include/belle-sip/listeningpoint.h
belle-sip-1.2.4/include/belle-sip/mainloop.h
belle-sip-1.2.4/include/belle-sip/refresher.h
belle-sip-1.2.4/ltmain.sh
belle-sip-1.2.4/src/auth_helper.c
belle-sip-1.2.4/src/belle_sdp_impl.c
belle-sip-1.2.4/src/belle_sip_dict.c
belle-sip-1.2.4/src/belle_sip_utils.c
belle-sip-1.2.4/src/clock_gettime.h
belle-sip-1.2.4/src/port.c
belle-sip-1.2.4/src/siplistener.c
belle-sip-1.2.4/src/transports/stream_channel.h
belle-sip-1.2.4/src/transports/tunnel_channel.c
belle-sip-1.2.4/src/transports/tunnel_listeningpoint.c
belle-sip-1.2.4/src/transports/tunnel_wrapper.cc
belle-sip-1.2.4/tester/auth_helper_tester.c
belle-sip-1.2.4/tester/belle_sdp_tester.c
belle-sip-1.2.4/tester/belle_sip_dialog_tester.c
belle-sip-1.2.4/tester/belle_sip_headers_tester.c
belle-sip-1.2.4/tester/belle_sip_message_tester.c
belle-sip-1.2.4/tester/belle_sip_refresher_tester.c
belle-sip-1.2.4/tester/belle_sip_tester.c
belle-sip-1.2.4/tester/belle_sip_tester.h
belle-sip-1.2.4/tester/belle_sip_uri_tester.c
belle-sip-1.2.4/tester/cast_test.c
belle-sip-1.2.4/tester/parse.c

GPL (v3 or later)
-----------------
belle-sip-1.2.4/include/belle-sip/belle-sip.h
belle-sip-1.2.4/include/belle-sip/defs.h
belle-sip-1.2.4/include/belle-sip/dict.h
belle-sip-1.2.4/include/belle-sip/headers.h
belle-sip-1.2.4/include/belle-sip/listener.h
belle-sip-1.2.4/include/belle-sip/message.h
belle-sip-1.2.4/include/belle-sip/object.h
belle-sip-1.2.4/include/belle-sip/parameters.h
belle-sip-1.2.4/include/belle-sip/provider.h
belle-sip-1.2.4/include/belle-sip/resolver.h
belle-sip-1.2.4/include/belle-sip/sipstack.h
belle-sip-1.2.4/include/belle-sip/transaction.h
belle-sip-1.2.4/include/belle-sip/utils.h
belle-sip-1.2.4/src/auth_event.c
belle-sip-1.2.4/src/belle_sip_headers_impl.c
belle-sip-1.2.4/src/belle_sip_internal.h
belle-sip-1.2.4/src/belle_sip_loop.c
belle-sip-1.2.4/src/belle_sip_object.c
belle-sip-1.2.4/src/belle_sip_parameters.c
belle-sip-1.2.4/src/belle_sip_resolver.c
belle-sip-1.2.4/src/belle_sip_uri_impl.c
belle-sip-1.2.4/src/channel.c
belle-sip-1.2.4/src/channel.h
belle-sip-1.2.4/src/dialog.c
belle-sip-1.2.4/src/ict.c
belle-sip-1.2.4/src/ist.c
belle-sip-1.2.4/src/listeningpoint.c
belle-sip-1.2.4/src/listeningpoint_internal.h
belle-sip-1.2.4/src/message.c
belle-sip-1.2.4/src/nict.c
belle-sip-1.2.4/src/nist.c
belle-sip-1.2.4/src/port.h
belle-sip-1.2.4/src/provider.c
belle-sip-1.2.4/src/refresher.c
belle-sip-1.2.4/src/sipstack.c
belle-sip-1.2.4/src/transaction.c
belle-sip-1.2.4/src/transports/stream_channel.c
belle-sip-1.2.4/src/transports/stream_listeningpoint.c
belle-sip-1.2.4/src/transports/tls_channel_polarssl.c
belle-sip-1.2.4/src/transports/tls_listeningpoint_polarssl.c
belle-sip-1.2.4/src/transports/udp_channel.c
belle-sip-1.2.4/src/transports/udp_listeningpoint.c
belle-sip-1.2.4/tester/belle_sip_core_tester.c
belle-sip-1.2.4/tester/belle_sip_register_tester.c
belle-sip-1.2.4/tester/belle_sip_resolver_tester.c
belle-sip-1.2.4/tester/describe.c

MIT/X11 (BSD like)
------------------
belle-sip-1.2.4/src/dns.c
belle-sip-1.2.4/src/dns.h

Unknown or generated
--------------------
belle-sip-1.2.4/include/belle-sip/uri.h
belle-sip-1.2.4/tester/register_tester.h

zlib/libpng
-----------
belle-sip-1.2.4/src/md5.c
belle-sip-1.2.4/src/md5.h

It has bundled code.
---------------

Small request, is it possible of you to change your name in Bugzilla from
nucleo to your real name ;) ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]