[Bug 1048621] Review Request: zabbix22 - Open-source monitoring solution for your IT infrastructure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1048621



--- Comment #8 from Volker Fröhlich <volker27@xxxxxx> ---
(In reply to Orion Poplawski from comment #5)
> Some general comments:
> 
> - Start with a fresh %changelog
> - If this is really EPEL only, why keep all of the Fedora conditionals?
>

So far I tried to keep the version for latest EPEL and Zabbix in sync. My idea
was to introduce the systemd macros on the EPEL7 file, drop the init script and
keep that in sync with Fedora then. It's a bit of a mess, as they don't share a
repository, but it worked for me so far. That's also why the changelog is still
there. I've trimmed it down to 2.0 and up though.

> This isn't needed any more:
> 
> # Logrotate's su option is currently only available in Fedora
> %if 0%{?rhel}
> sed -i '/su zabbix zabbix/d' %{SOURCE5}
> %endif

Are you sure about the logrotate stanza? Can you point me to where this was
sorted out?

> - This has long been a bug in zabbix_agentd.conf:
> 
> Hostname=Zabbix server
> 
> This should be left unset.

Leaving it unset would break active checks, I think but it's one of the better
ideas I've heard so far.

We discussed the Hostname matter on
https://bugzilla.redhat.com/show_bug.cgi?id=825833 and failed to come up with
something useful.

> - Upgrading to 2.2 from 2.0 triggered a whole slew of "OK" email messages

I'd need more information on the triggers/events.

> - Seeing: 
> 
>   8532:20140106:142129.396 /var/lib/zabbixsrv/tmp/zabbix_server_8532.pinger:
> [13] Permission denied
> 
> # ls -ld /var/lib/zabbixsrv/tmp
> drwxr-x---. 2 root zabbixsrv 4096 Jan  6 14:01 /var/lib/zabbixsrv/tmp

Good catch; changed.

The permission on remaining files should be in the domain of the administrator,
I think. There's a note on the matter in the README.

> - Not sure about this:
> # rpm -V zabbix22
> Unsatisfied dependencies for zabbix22-2.2.1-1.1.el6_4.x86_64:
>         zabbix conflicts with zabbix22-2.2.1-1.1.el6_4.x86_64
>         zabbix conflicts with zabbix22-2.2.1-1.1.el6_4.x86_64
> 
> Perhaps a problem with providing and conflicting with zabbix?

I hadn't provided versions!

> - Group change seems okay, and worked for me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]