https://bugzilla.redhat.com/show_bug.cgi?id=1048667 --- Comment #8 from Bohuslav "Slavek" Kabrda <bkabrda@xxxxxxxxxx> --- (In reply to Lokesh Mandvekar from comment #7) > > - As for the tests, have you tried removing the requirements.txt prior to > > executing the test suite? That should help, IMHO. > > setup.py seems to use requirements.txt so deleting that file complains. > Should I request upstream to use >= instead of == ? Oh, I didn't notice that the upstream doesn't ship the test suite... So it would be ideal if you could ask them to ship the test suite and to relax dependencies. If they won't agree to relaxing dependencies, I'd suggest patching setup.py (emptying the requirements list), so that it doesn't complain. So for this review, let's just skip the tests and I'll leave it up to you to add them there when upstream releases new version (BTW for commented macros, you should double all the percent signs, as noted in [1] (rpmlint complains about that, too)). Note that you'll also need to add all the Requires as BuildRequires, too, since they'll be needed for tests (but are not needed now). Some more comments: - The section "%description -n python3-docker-py" should be in the with_python3 conditional, too. - The rpmlint "no binary" and "empty debuginfo package" are sort of an rpmlint bug. It doesn't expect ExclusiveArch packages to not contain any binary code (and thus not producing any debuginfo packages), but due to docker-io limitation to x86_64 we can ignore it in this case. - The only "really blocking" problem is now having "python3-websocket-client". So when you fix the description as mentioned above and python3-websocket-client package is added, I'll approve this, everything else looks fine now. [1] https://fedoraproject.org/wiki/How_to_create_an_RPM_package#SPEC_file_overview -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review