[Bug 1048667] Review Request: python-docker - An API client for docker written in Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1048667

Bohuslav "Slavek" Kabrda <bkabrda@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED



--- Comment #6 from Bohuslav "Slavek" Kabrda <bkabrda@xxxxxxxxxx> ---
- The reason of mandating the "python-" prefix rule is, that packages in Fedora
should have predictable names derived from upstream names. Previously, there
were three naming schemes that different packagers used for their packages:
 * docker-py
 * python-docker
 * python-docker-py
This led to unpredictable names. I was hitting this issue from time to time, I
had to try 3 yum installs or do yum search before knowing what to install,
which took time. Then we agreed that we will have all the new packages named
"python-%{pypi_name}", whatever "%{pypi_name}" is. So the reason for the rule
is having predictable package names, therefore you should use python-docker-py.
I hope that makes sense.
- You should really put the stuff in the main package, it's the standard
approach for python extension modules. I never see the error you mentioned, but
I'll investigate it when you move the files. If rpmlint complains about this,
then it's a bug in rpmlint, not in your packaging :)
- Please request building python-websocket-client for python3, we can't push
the subpackage without dependencies.
- As for the tests, have you tried removing the requirements.txt prior to
executing the test suite? That should help, IMHO.
- Your runtime Requires are wrong. All the "Requires:" for python3 packages
should go to the python3- subpackage (which should not be -devel, too) + you
should also put Requires: docker-io to the subpackage. With your solution, the
python2-docker package would depend on all the python3- dependencies, but the
python3-docker package wouldn't, so you need to move them. The python- and
python3- packages just have to be independent of each other.
- You don't have to put the %defattr line in a rhel-6 condition. It won't do no
harm on Fedora. My note was just that if you do not mean to build in EPEL, you
won't need it at all. Since clearly you want to build in EPEL, just leave it
there as it was previously.

Thanks for your work on this!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]