https://bugzilla.redhat.com/show_bug.cgi?id=1048667 --- Comment #5 from Lokesh Mandvekar <lsm5@xxxxxxxxxx> --- Spec URL: http://fedorapeople.org/cgit/lsm5/public_git/python-docker.git/plain/SOURCES/python-docker.spec SRPM URL: http://fedorapeople.org/cgit/lsm5/public_git/python-docker.git/tree/SRPMS/python-docker-0.2.3-2.fc21.src.rpm (In reply to Bohuslav "Slavek" Kabrda from comment #2) > Few fly-by comments (I can take the full review if that's ok with you, I > really want this package in Fedora): > - You should consider running tests in %check section during build. Added but commented out for now, it complains python-six version mismatch, requirements.txt looks for six==1.3.0 but installed is 1.4.1. Any suggestions on overriding/patching/ignoring? > - Why is there only the -devel package? It doesn't make any sense to me. Why > not keep everything in the main package? When I only had the main package, rpmlint complained E: no-binary. That's why I put stuff in devel. Let me know if it should still go in the main package. > - You have many BuildRequires for python packages, but no Requires (runtime > deps) for those. Why? Are they not needed? It doesn't seem so. Checkout the new build and runtime deps > - Could you please consider adding python3- subpackage? Added. btw, 'import docker' on python3 fails. It says: NameError: name 'http' is not defined, probably because python-websocket-client isn't built for python3, we gotta request for that as well. > - AFAIK it'd be best to use PyPI as upstream [1], since it provides nice > urls and source archive that is actually named "docker-py-0.2.3.tar.gz" > (whereas the one from GH is named only "0.2.3.tar.gz"). Done. > - You should name the package python-docker-py. This naming convention was > agreed on at [2]. Currently at python-docker, but I'll rename it to python-docker-py if you still think latter is better. > - Unless you want to build this for epel, please drop the %defattr line from > %files, it's not needed for Fedora anymore. Yes, I'll be building for epel too. I added a conditional to check for epel, check that out as well. > - It seems to me that the package doesn't actually own > %{python_sitelib}/docker directory. Done. > > [1] https://pypi.python.org/pypi/docker-py > [2] https://fedorahosted.org/fpc/ticket/271 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review