https://bugzilla.redhat.com/show_bug.cgi?id=858084 Michael Cronenworth <mike@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #16 from Michael Cronenworth <mike@xxxxxxxxxx> --- $ rpmlint mingw-qt5-qtwebkit.spec mingw-qt5-qtwebkit.spec:30: W: macro-in-comment %{snapshot_rev} mingw-qt5-qtwebkit.spec:30: W: macro-in-comment %{snapshot_rev} 0 packages and 1 specfiles checked; 0 errors, 3 warnings. $ rpmlint mingw-qt5-qtwebkit-5.2.0-0.1.rc1.fc21.src.rpm mingw-qt5-qtwebkit.src: E: unknown-key GPG#9b393ae8 mingw-qt5-qtwebkit.src:30: W: macro-in-comment %{snapshot_rev} mingw-qt5-qtwebkit.src:30: W: macro-in-comment %{snapshot_rev} 1 packages and 0 specfiles checked; 1 errors, 4 warnings. + OK ! needs attention + The package is named according to Fedora MinGW packaging guidelines + The spec file name matches the base package name. + The package meets the Packaging Guidelines + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The license field in the spec file matches the actual license + The stated license is the same as the one for the corresponding native Fedora package + The package contains the license file (COPYING.lib) + Spec file is written in American English + Spec file is legible + Upstream sources match sources in the srpm. md5sum: 0236ee173b2ba63a6a98974ffd791261 Downloads/qtwebkit-opensource-src-5.2.0-rc1.tar.xz 0236ee173b2ba63a6a98974ffd791261 rpmbuild/SOURCES/qtwebkit-opensource-src-5.2.0-rc1.tar.xz + The package builds in koji n/a ExcludeArch bugs filed + BuildRequires look sane n/a locale handling n/a ldconfig in %post and %postun + Package does not bundle copies of system libraries n/a Package isn't relocatable + Package owns all directories it creates + No duplicate files in %files + Permissions are properly set + Consistent use of macros + The package must contain code or permissible content n/a Large documentation files should go in -doc subpackage + Files marked %doc should not affect package n/a Header files should be in -devel Not applicable to MinGW packages. n/a Static libraries should be in -static n/a Library files that end in .so must go in a -devel package n/a -devel must require the fully versioned base + Packages must not contain libtool .la files n/a Packages containing GUI apps must include %{name}.desktop file + Directory ownership sane + Filenames are valid UTF-8 ----- APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review