https://bugzilla.redhat.com/show_bug.cgi?id=1048966 --- Comment #2 from Francesco Frassinelli <fraph24@xxxxxxxxx> --- (In reply to Antonio Trande from comment #1) > Hi Francesco. > Just few comments. > > - Description has too long lines. I tried to fix it. > - Documentation files (above all the license file) are missing; the source > archive provides them. ;) > See http://fedoraproject.org/wiki/Packaging:Guidelines#Documentation > > - %doc %{_mandir}/man1/seren.1.gz > Don't mark this line as %doc. Fixed. > - Where did you take that patch from ? Does it come from upstream or is it > your ? It's mine. > Please leave a comment or a link. > http://fedoraproject.org/wiki/Packaging: > Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment Commented. Should I write that is mine? If so, where? > - Changelog already starts with a release number 2 ? > http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs Reverted to 1. It was two because I have a repo on copr and I've already made a second revision for this version. Here they are the new information: Spec URL: http://frafra.fedorapeople.org/copr/seren/seren.spec SRPM URL: http://frafra.fedorapeople.org/copr/seren/seren-0.0.16-1.fc20.src.rpm Description: Seren is a simple VoIP program based on the Opus codec. With Seren you can create a voice conference from the terminal, with up to 10 participants: all you need to join an existing conference is the hostname or IP address of one of the participants. It creates a dynamic peer-to-peer network of equivalent nodes which exchange text and audio data using a UDP connection. You can also change the quality/bitrate on the fly, encrypt the traffic and record the calls. Thanks for your feedback! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review