https://bugzilla.redhat.com/show_bug.cgi?id=1047600 --- Comment #4 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- Issues: ======= [!]: Requires correct, justified where necessary. From package.xml, optional: php-mcrypt Packager choice, but probably better for perf, and available. [!]: Rpmlint is run on all rpms the build produces. W: invalid-url URL: http://phpseclib.sourceforge.net/package/Crypt_AES HTTP Error 404: Not Found [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. As you have a link to the license file in package.xml you can add this file to the package, which will avoid having to block this review for missing License. My though: this library stack is mostly a wrapper above mcrypt (probably used as some distro, like RHEL, don't have mcrypt), so It think it worth requiring it, as C implementation will be faster than pure PHP one. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review