https://bugzilla.redhat.com/show_bug.cgi?id=1047604 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #4 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- [!]: Rpmlint is run on all rpms the build produces. invalid-url URL: http://phpseclib.sourceforge.net/package/Crypt_Random HTTP Error 404: Not Found [!]: Requires correct, justified where necessary. # Optional, From package.xml Requires: php-openssl Requires: php-mcrypt Requires: php-pear(phpseclib.sourceforge.net/Crypt_AES) >= 0.2.1 Requires: php-pear(phpseclib.sourceforge.net/Crypt_TripleDES) >= 0.2.1 Requires: php-pear(phpseclib.sourceforge.net/Crypt_DES) >= 0.2.1 Requires: php-pear(phpseclib.sourceforge.net/Crypt_RC4) >= 0.2.1 This is your choice to require or not optional dep. I personnally think it's better for user experience, especially as this doesn't pull "huge" thing, only small pure PHP library. [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. As you have a link to the license file in package.xml you can add this file to the package, which will avoid having to block this review for missing License. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review