[Bug 1046340] Review Request: qtkeychain - A cross platform password store library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1046340



--- Comment #11 from Kevin Kofler <kevin@xxxxxxxxxxxxxxxx> ---
> Also it has a tag 0.1.0, so your version should be 0.1.0.git(DATE).(COMMIT)

Uh, no, snapshot dates do not belong in Version, but Release.

In this case, it is a post-release snapshot (i.e., it is NEWER than the 0.1.0
tag), so it should have:
Version: 0.1.0
Release: 1.20130805git%{?dist}
(then 2.20130805git%{?dist}, 3.20130805git%{?dist} etc. if you need to do
changes to the specfile).
Optionally, IN ADDITION to the date (which is always required and comes BEFORE
"git"), the git hash can be added after "git", with up to 13 characters (and if
you do that, I recommend using all 13 characters that the packaging guidelines
allow because collisions have been seen in the wild for shorter abbreviations:
http://blog.cuviper.com/2013/11/10/how-short-can-git-abbreviate/).

For pre-release snapshots, the rules are almost the same, but there you have to
use 0.1, 0.2 etc. instead of 1, 2 etc., so that the actual release can get
Release: 1%{?dist}.

See:
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Versioning
which states all these rules very clearly. I don't understand why even
reviewers keep getting this wrong!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]