https://bugzilla.redhat.com/show_bug.cgi?id=1048299 --- Comment #8 from Will Benton <willb@xxxxxxxxxx> --- Hi Gil, Thanks for your review. I've updated the package in place to fix all of your concerns, including replacing the bundled code with equivalent functionality from the Java standard library. (It seems like a lot of projects use that ImageInfo class as a copylib; it might be a good candidate for a separate package, but this was less effort.) Although it no longer applies to this package, you should note that "or" in a license is appropriate only for dual-licensed packages and would not apply to a BSD-licensed package that incorporated public-domain code. In the case of a package with, e.g., both BSD and LGPL code, the license would be an "and" license, but public domain code has no restrictions on use. See https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#Dual_Licensing_Scenarios Here are the remaining rpmlint issues, with explanations: fmpp.src: W: spelling-error %description -l en_US preprocessor -> processor, predecessor, process's fmpp.noarch: W: spelling-error %description -l en_US preprocessor -> processor, predecessor, process's This is not actually a spelling error. fmpp.noarch: W: file-not-utf8 /usr/share/doc/fmpp-0.9.14/LICENSE.txt fmpp-javadoc.noarch: W: file-not-utf8 /usr/share/doc/fmpp-javadoc-0.9.14/LICENSE.txt We aren't allowed to modify licenses for legal reasons, so I can't munge the character set. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review